Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 684783010: Add unit test for VirtualMemory::Commit. (Closed)

Created:
6 years, 1 month ago by koda
Modified:
6 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add unit test for VirtualMemory::Commit. Better late than never. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M runtime/vm/virtual_memory_test.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 1 month ago (2014-11-05 21:49:59 UTC) #1
Ivan Posva
LGTM -ip
6 years, 1 month ago (2014-11-06 00:22:30 UTC) #2
koda
6 years, 1 month ago (2014-11-06 00:26:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r41539 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698