Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 684783005: Redirect blink calls through instance (Closed)

Created:
6 years, 1 month ago by Leaf
Modified:
6 years, 1 month ago
Reviewers:
vsm, terry
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Redirect blink calls through instance Use a singleton instance object for dispatching calls from dart:html to dart:blink to make code more resilient against changes in web idl. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3957 lines, -3956 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 499 chunks +2791 lines, -2791 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 11 chunks +96 lines, -96 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 105 chunks +695 lines, -695 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 25 chunks +156 lines, -156 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 14 chunks +194 lines, -194 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 6 chunks +21 lines, -21 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Leaf
6 years, 1 month ago (2014-10-28 21:58:28 UTC) #2
vsm
lgtm
6 years, 1 month ago (2014-10-28 22:51:41 UTC) #3
Leaf
6 years, 1 month ago (2014-10-28 23:11:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698