Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 684183002: Refactor CompletionSuggestionKind (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Refactor CompletionSuggestionKind - Remove many CompletionSuggestionKinds that duplicate ElementKind - Add two new CompletionSuggestionKinds: INVOCATION and IDENTIFIER - regenerate Analysis Server Dart and Java API and docs - rework Dart and Java tests - remove/rename unused Dart and Java classes and methods - remove unnecessary reference to SDK BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41396

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -4319 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestionKind.java View 1 chunk +17 lines, -30 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 5 chunks +30 lines, -6 lines 0 comments Download
D editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ProxyProposal_NEW.java View 1 chunk +0 lines, -243 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartEditor.java View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +23 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 3 chunks +25 lines, -74 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 4 chunks +7 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 11 chunks +15 lines, -22 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 10 chunks +21 lines, -47 lines 0 comments Download
D pkg/analysis_server/lib/src/services/generated/completion.dart View 1 chunk +0 lines, -3700 lines 0 comments Download
A + pkg/analysis_server/lib/src/services/generated/completion.dart.unused View 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 5 chunks +11 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +5 lines, -31 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_computer_test.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 20 chunks +140 lines, -68 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +25 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
6 years, 1 month ago (2014-10-29 14:56:24 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-29 15:43:09 UTC) #3
scheglov
LGTM
6 years, 1 month ago (2014-10-29 16:01:17 UTC) #4
danrubel
6 years, 1 month ago (2014-10-29 16:10:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 41396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698