added support for more types of transformer sections in new_entry script

added support for more types of transformer sections in new_entry script

BUG= http://dartbug.com/21512
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41722

[jakemac, 2014-11-11 20:26:40]

jakemac@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2014-11-12 19:46:36]

https://codereview.chromium.org/683883004/diff/40001/pkg/polymer/bin/new_entr...
File pkg/polymer/bin/new_entry.dart (right):

https://codereview.chromium.org/683883004/diff/40001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:129: entryPoints = [entryPoint];
we should save the pubspec span location of "- polymer" in this case, otherwise
we might be changing the order of the transformers. For example:

transformers:
- foo
- bar
- polymer
- baz

will change to:

transformers:
- polymer
    entry_points:
    - new_entry
- foo
- bar
- baz

https://codereview.chromium.org/683883004/diff/40001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:140: ' the `web/` folder. You will need to
hardcode all entry points'
nit: replace "hardcode" with "explicitly list" (hardcode sounds like a hacky
thing to do :-))

[jakemac, 2014-11-12 21:49:10]

https://codereview.chromium.org/683883004/diff/40001/pkg/polymer/bin/new_entr...
File pkg/polymer/bin/new_entry.dart (right):

https://codereview.chromium.org/683883004/diff/40001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:129: entryPoints = [entryPoint];
On 2014/11/12 19:46:36, Siggi Cherem (dart-lang) wrote:
> we should save the pubspec span location of "- polymer" in this case,
otherwise
> we might be changing the order of the transformers. For example:
> 
> transformers:
> - foo
> - bar
> - polymer
> - baz
> 
> will change to:
> 
> transformers:
> - polymer
>     entry_points:
>     - new_entry
> - foo
> - bar
> - baz

Done.

https://codereview.chromium.org/683883004/diff/40001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:140: ' the `web/` folder. You will need to
hardcode all entry points'
On 2014/11/12 19:46:36, Siggi Cherem (dart-lang) wrote:
> nit: replace "hardcode" with "explicitly list" (hardcode sounds like a hacky
> thing to do :-))

Done.

[Siggi Cherem (dart-lang), 2014-11-12 23:02:55]

lgtm

https://codereview.chromium.org/683883004/diff/60001/pkg/polymer/bin/new_entr...
File pkg/polymer/bin/new_entry.dart (right):

https://codereview.chromium.org/683883004/diff/60001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:119: SourceSpan transformersSourceSpan =
transformers.span;
sorry I missed this earlier - I guess we should use `var` for all of these

https://codereview.chromium.org/683883004/diff/60001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:184: // TODO(dgrove): Once dartbug.com/20409 is
addressed, use that here.
move TODO one line down

[jakemac, 2014-11-13 17:09:33]

Committed patchset #5 (id:80001) manually as 41722 (presubmit successful).

[jakemac, 2014-11-13 17:49:27]

https://codereview.chromium.org/683883004/diff/60001/pkg/polymer/bin/new_entr...
File pkg/polymer/bin/new_entry.dart (right):

https://codereview.chromium.org/683883004/diff/60001/pkg/polymer/bin/new_entr...
pkg/polymer/bin/new_entry.dart:119: SourceSpan transformersSourceSpan =
transformers.span;
On 2014/11/12 23:02:55, Siggi Cherem (dart-lang) wrote:
> sorry I missed this earlier - I guess we should use `var` for all of these

Keeping it for now for code completion purposes :(