Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 683803003: Support for loops in analyzer2dart. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support for loops in analyzer2dart. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41355

Patch Set 1 #

Patch Set 2 : Add TODO. #

Total comments: 2

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -151 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/lib/src/dart_backend.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 chunk +73 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 2 3 chunks +170 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 4 chunks +12 lines, -145 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-10-28 12:10:58 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/683803003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/683803003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode800 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:800: /// Creates a sequence of [nodes] by applying ...
6 years, 1 month ago (2014-10-28 12:33:58 UTC) #3
Johnni Winther
https://codereview.chromium.org/683803003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/683803003/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart#newcode800 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart:800: /// Creates a sequence of [nodes] by applying [build] ...
6 years, 1 month ago (2014-10-28 12:48:47 UTC) #4
Johnni Winther
Committed patchset #3 (id:40001) manually as 41355 (presubmit successful).
6 years, 1 month ago (2014-10-28 12:53:54 UTC) #5
Paul Berry
6 years, 1 month ago (2014-10-28 15:31:12 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698