Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 683573003: Fix analysis server asynchrony test. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix analysis server asynchrony test. The test had two bugs: it neglected to account for the "server.connected" notification, and it failed to allow the test to run to completion before reporting success. The second bug sometimes covered up the first, making it look like the test succeeded. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/analysis_server/test/integration/asynchrony_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-10-27 21:53:13 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-27 22:57:23 UTC) #3
Paul Berry
6 years, 1 month ago (2014-10-27 23:19:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698