Issue 68333007: Handle undefined field/getter access from arguments to const constructors in metadata, and related …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68333007: Handle undefined field/getter access from arguments to const constructors in metadata, and related … (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle undefined field/getter access from arguments to const constructors in metadata, and related problematic cases. BUG=http://dartbug.com/13817 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=30385

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -1 line)			Patch
M	runtime/vm/parser.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	6 chunks	+19 lines, -0 lines	0 comments	Download
M	tests/lib/mirrors/metadata_allowed_values_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	tests/lib/mirrors/metadata_constructor_arguments_test.dart	View		1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM w/comment https://codereview.chromium.org/68333007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/68333007/diff/1/runtime/vm/parser.cc#newcode8253 runtime/vm/parser.cc:8253: if (parsing_metadata_ || Please add to the ...

7 years, 1 month ago (2013-11-19 00:07:24 UTC) #2

rmacnak

https://codereview.chromium.org/68333007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/68333007/diff/1/runtime/vm/parser.cc#newcode8253 runtime/vm/parser.cc:8253: if (parsing_metadata_ || On 2013/11/19 00:07:24, hausner wrote: > ...

7 years, 1 month ago (2013-11-19 01:01:23 UTC) #3

rmacnak

7 years, 1 month ago (2013-11-19 01:02:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30385 (presubmit successful).

Expand Messages | Collapse Messages