Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 683323002: Add SpanScanner.location. (Closed)

Created:
6 years, 1 month ago by nweiz
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add SpanScanner.location. Also explicitly expose FileSpans and FileLocations. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=41383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M pkg/string_scanner/CHANGELOG.md View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/string_scanner/lib/src/span_scanner.dart View 1 chunk +10 lines, -7 lines 0 comments Download
M pkg/string_scanner/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 1 month ago (2014-10-28 21:59:00 UTC) #1
Bob Nystrom
lgtm
6 years, 1 month ago (2014-10-28 22:15:17 UTC) #2
nweiz
6 years, 1 month ago (2014-10-29 00:53:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698