Reland 30137 - Fix version generation for dart2js

Reland 30137 - Fix version generation for dart2js

Not, without eating the first command line argument to dart2js

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30142

[ricow1, 2013-11-11 06:50:32]

https://codereview.chromium.org/68323003/diff/1/utils/compiler/create_snapsho...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/68323003/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:55: dart2jsMain.main(arguments);
In r30138 I eat the first argument here like we do in the utils_wrapper (where
the first argument is name of the tool)

[kasperl, 2013-11-11 06:58:07]

LGTM.

https://codereview.chromium.org/68323003/diff/1/utils/compiler/create_snapsho...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/68323003/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:51: import 'dart:io';
What do you use dart:io for?

[ricow1, 2013-11-11 07:32:29]

Committed patchset #2 manually as r30142 (presubmit successful).

[ricow1, 2013-11-11 07:33:31]

https://codereview.chromium.org/68323003/diff/1/utils/compiler/create_snapsho...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/68323003/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:51: import 'dart:io';
On 2013/11/11 06:58:07, kasperl wrote:
> What do you use dart:io for?

Leftover from when we needed to get the arguments I think, removed

[kustermann, 2013-11-11 07:34:21]

LGTM

[ahe, 2013-11-11 08:11:10]

lgtm