Issue 682553002: Convert most of the EngineTestCase.createSource invocations into multi-line String literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 682553002: Convert most of the EngineTestCase.createSource invocations into multi-line String literals. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Convert most of the EngineTestCase.createSource invocations into multi-line String literals. There are sill invocations in Angular tests, but these call it with List<String>, I will clean them up in the following CL. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41308

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10603 lines, -8766 lines)			Patch
M	pkg/analyzer/test/generated/all_the_rest.dart	View	68 chunks	+902 lines, -993 lines	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	2 chunks	+25 lines, -21 lines	0 comments	Download
M	pkg/analyzer/test/generated/compile_time_error_code_test.dart	View	106 chunks	+1999 lines, -1410 lines	0 comments	Download
M	pkg/analyzer/test/generated/element_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/engine_test.dart	View	49 chunks	+273 lines, -192 lines	0 comments	Download
M	pkg/analyzer/test/generated/non_error_resolver_test.dart	View	41 chunks	+2429 lines, -1995 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	11 chunks	+42 lines, -24 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	160 chunks	+2584 lines, -2249 lines	0 comments	Download
M	pkg/analyzer/test/generated/scanner_test.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/static_type_warning_code_test.dart	View	7 chunks	+717 lines, -591 lines	0 comments	Download
M	pkg/analyzer/test/generated/static_warning_code_test.dart	View	34 chunks	+1621 lines, -1287 lines	0 comments	Download
M	pkg/analyzer/test/generated/test_support.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/task/task_dart_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 1 month ago (2014-10-26 22:03:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41308 (presubmit successful).

Expand Messages | Collapse Messages