Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 682243004: Redo "Constant fold charCodeAt via constant system" (Closed)

Created:
6 years, 1 month ago by sra1
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Redo "Constant fold charCodeAt via constant system" TBR=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41384

Patch Set 1 #

Patch Set 2 : Fix analysis warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/constant_system.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/constant_system_dart.dart View 1 2 chunks +32 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart View 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart View 2 chunks +21 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/constant_folding_codeUnitAt_test.dart View 1 chunk +45 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 2 chunks +1 line, -1 line 0 comments Download
M tests/language/compile_time_constant_c_test.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #2 (id:20001) manually as 41384 (presubmit successful).
6 years, 1 month ago (2014-10-29 01:00:15 UTC) #1
Johnni Winther
6 years, 1 month ago (2014-10-29 07:44:25 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698