Issue 68203020: Reapply "Fix issues with field names by ensuring that fields have exactly one name regardless of ho…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68203020: Reapply "Fix issues with field names by ensuring that fields have exactly one name regardless of ho… (Closed)

Created:
7 years, 1 month ago by sra1

Modified:
7 years, 1 month ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Fix issues with field names by ensuring that fields have exactly one name regardless of how the class is extended or mixed." One additional test started passing, two tests were failing because we generated a gibberish JavaScript property. Committed: https://code.google.com/p/dart/source/detail?r=30265

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -62 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1	4 chunks	+68 lines, -19 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View		2 chunks	+2 lines, -14 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		4 chunks	+3 lines, -11 lines	0 comments	Download
M	tests/compiler/dart2js_native/dart2js_native.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js_native/native_mixin_field_test.dart	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #2 manually as r30265 (presubmit successful).

7 years, 1 month ago (2013-11-14 03:02:14 UTC) #1

Message was sent while issue was closed.

Still LGTM

Expand Messages | Collapse Messages