Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 681543002: Constant fold codeUnitAt via constant system (Closed)

Created:
6 years, 1 month ago by sra1
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Constant fold charCodeAt via constant system BUG= R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=41381

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add test #

Patch Set 4 : Add language test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/constant_system.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/constant_system_dart.dart View 1 2 chunks +30 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_system_javascript.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/invoke_dynamic_specializers.dart View 2 chunks +21 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/constant_folding_codeUnitAt_test.dart View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M tests/language/compile_time_constant_c_test.dart View 1 2 3 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
sra1
I wanted to constant-fold 'a'.codeUnitAt(0) It seemed that the ConstantSystem was a good place to ...
6 years, 1 month ago (2014-10-25 03:37:58 UTC) #2
Johnni Winther
Could you add a unit test for this feature?
6 years, 1 month ago (2014-10-27 09:44:48 UTC) #3
sra1
PTAL
6 years, 1 month ago (2014-10-27 22:53:12 UTC) #4
Johnni Winther
LGTM Would be nice with a language test that ''.codeUnitAt(0) is not a compile time ...
6 years, 1 month ago (2014-10-28 07:37:48 UTC) #5
sra1
6 years, 1 month ago (2014-10-28 23:58:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 41381 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698