Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 68133017: Remove the --use_browser_controller flag, now that it is always true. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove the --use_browser_controller flag, now that it is always true. Fix an error in r30269. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=30270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -39 lines) Patch
M tools/bots/compiler.py View 2 chunks +0 lines, -26 lines 0 comments Download
M tools/test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 3 chunks +3 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-11-14 13:41:28 UTC) #1
kustermann
LGTM
7 years, 1 month ago (2013-11-14 13:48:06 UTC) #2
Bill Hesse
7 years, 1 month ago (2013-11-14 15:20:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698