Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 68113022: Remove use of deprecated mirror functions from Polymer. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove use of deprecated mirror functions from Polymer. BUG=http://dartbug.com/14931 BUG=http://dartbug.com/14878 R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30292

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M pkg/polymer/lib/src/declaration.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmacnak
Redoing after revert. How do I run Polymer's tests locally? I tried test.py pkg, but ...
7 years, 1 month ago (2013-11-14 20:08:57 UTC) #1
Jennifer Messerly
for tests: pkg/polymer/test/run.sh is a nice helper. It just runs these two commands: ./tools/test.py -m ...
7 years, 1 month ago (2013-11-14 20:21:56 UTC) #2
Jennifer Messerly
lgtm
7 years, 1 month ago (2013-11-14 20:22:58 UTC) #3
rmacnak
On 2013/11/14 20:21:56, John Messerly wrote: > for tests: pkg/polymer/test/run.sh is a nice helper. It ...
7 years, 1 month ago (2013-11-14 21:43:53 UTC) #4
rmacnak
7 years, 1 month ago (2013-11-14 21:44:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r30292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698