Issue 68113013: Do not skip unfinalized interfaces while checking type bounds at finalization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68113013: Do not skip unfinalized interfaces while checking type bounds at finalization (Closed)

Created:
7 years, 1 month ago by regis

Modified:
7 years, 1 month ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not skip unfinalized interfaces while checking type bounds at finalization time (fix issue 14721). Fix BoundedType::ToCString() to handle a null type parameter. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=30250

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -14 lines)			Patch
	M	runtime/vm/object.cc	View	1	2 chunks	+22 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://codereview.chromium.org/68113013/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/68113013/diff/1/runtime/vm/object.cc#newcode2851 runtime/vm/object.cc:2851: thsi, interface, ClassFinalizer::kCanonicalize); This name threw me off, ...

7 years, 1 month ago (2013-11-13 20:51:46 UTC) #3

regis

Thanks! https://codereview.chromium.org/68113013/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/68113013/diff/1/runtime/vm/object.cc#newcode2851 runtime/vm/object.cc:2851: thsi, interface, ClassFinalizer::kCanonicalize); On 2013/11/13 20:51:46, hausner wrote: ...

7 years, 1 month ago (2013-11-13 20:58:01 UTC) #4

regis

7 years, 1 month ago (2013-11-13 20:58:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r30250 (presubmit successful).

Expand Messages | Collapse Messages