Issue 68103016: When ClassMirrors are created by enumerating members of a LibraryMirror, have the ClassMirror use t…

Issue 68103016: When ClassMirrors are created by enumerating members of a LibraryMirror, have the ClassMirror use t… (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

When ClassMirrors are created by enumerating members of a LibraryMirror, have the ClassMirror use that LibraryMirror as its owner. BUG=http://dartbug.com/14449 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30291

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : sync #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -21 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tests/lib/mirrors/hierarchy_invariants_test.dart	View	1 2	2 chunks	+9 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmacnak

The hierarchy invariants test was slow because of a performance bug in the VM's mirrors. ...

7 years, 1 month ago (2013-11-13 21:41:32 UTC) #1

The hierarchy invariants test was slow because of a performance bug in the VM's
mirrors. The time to check a library was actually quadratic in the number of
classes in that library because ClassMirrors were not initialized with their
owner LibraryMirror. This meant checking each class was its owner's value using
its own name as the key involved creating a new LibraryMirror for each class and
populating each of those LibraryMirror's members lists.

Processing dart:html is now 10x faster.


BEFORE
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.core' in 1941
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.mirrors' in 342
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 3
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.typed_data' in 979
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.async' in 3997
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.convert' in 1734
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.collection' in 2108
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart._collection@0x1aab143.dev' in
546
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.isolate' in 44
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.math' in 56
CONSOLE MESSAGE: line 38: LibraryMirror on 'snapshot' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.html' in 98201
CONSOLE MESSAGE: line 38: LibraryMirror on 'html_common' in 22
CONSOLE MESSAGE: line 38: LibraryMirror on 'metadata' in 5
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.indexed_db' in 59
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.web_gl' in 4671
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.web_sql' in 21
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.svg' in 14486
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.web_audio' in 146
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.js' in 13
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on 'test.hierarchy_invariants_test' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on 'expect' in 2
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 0

AFTER
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.core' in 574
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.mirrors' in 109
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 1
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.typed_data' in 93
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.async' in 1582
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.convert' in 489
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.collection' in 972
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart._collection@0x1aab143.dev' in
401
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.isolate' in 32
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.math' in 22
CONSOLE MESSAGE: line 38: LibraryMirror on 'snapshot' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.html' in 9886
CONSOLE MESSAGE: line 38: LibraryMirror on 'html_common' in 20
CONSOLE MESSAGE: line 38: LibraryMirror on 'metadata' in 2
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.indexed_db' in 36
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.web_gl' in 172
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.web_sql' in 14
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.svg' in 700
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.dom.web_audio' in 1156
CONSOLE MESSAGE: line 38: LibraryMirror on 'dart.js' in 10
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on 'test.hierarchy_invariants_test' in 0
CONSOLE MESSAGE: line 38: LibraryMirror on 'expect' in 1
CONSOLE MESSAGE: line 38: LibraryMirror on '' in 0

https://codereview.chromium.org/68103016/diff/1/tests/lib/mirrors/hierarchy_i...
File tests/lib/mirrors/hierarchy_invariants_test.dart (left):

https://codereview.chromium.org/68103016/diff/1/tests/lib/mirrors/hierarchy_i...
tests/lib/mirrors/hierarchy_invariants_test.dart:16: if (classMirror is
TypedefMirror) return;
Can't happen anymore since TypedefMirror is no longer a subtype of ClassMirror.

https://codereview.chromium.org/68103016/diff/1/tests/lib/mirrors/hierarchy_i...
tests/lib/mirrors/hierarchy_invariants_test.dart:42: Expect.throws(() =>
reflectClass(dynamic),
Covered in another test.

rmacnak

7 years, 1 month ago (2013-11-14 20:36:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r30291 (presubmit successful).

Expand Messages | Collapse Messages