Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 681003002: Replace ${name} with $name where possible. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace ${name} with $name where possible. ...i.e. when the next character is not a part of an identifier. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41333

Patch Set 1 #

Patch Set 2 : Clean up also implementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -192 lines) Patch
M pkg/analyzer/lib/source/package_map_resolver.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/source/pub_package_map_provider.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/analyzer_impl.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 1 9 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 9 chunks +10 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 7 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/services/runtime/coverage/models.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/services/runtime/log.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 24 chunks +44 lines, -44 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 8 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 16 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-10-27 18:38:58 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-27 19:21:04 UTC) #2
scheglov
6 years, 1 month ago (2014-10-27 19:44:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41333 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698