Issue 680913006: Stop generating dart:blink from dart scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 680913006: Stop generating dart:blink from dart scripts (Closed)

Created:
6 years, 1 month ago by Leaf

Modified:
6 years, 1 month ago

Reviewers:
vsm, terry

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Stop generating dart:blink from dart scripts This removes the dart:blink generation code from the dart html scripts. The _blink_dartium template is removed, and the blink_nativeDOMImplementation html_nativeDOMImplementation split is eliminated, with the code for the former in the dartium generated code, and the latter moved back to native_DOMImplementation.dart. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41346

Patch Set 1 #

Patch Set 2 : Add dartium generated dart:blink to sdk #

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+524 lines, -1288 lines)			Patch
M	tools/dom/scripts/dartdomgenerator.py	View	3 chunks	+2 lines, -11 lines	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	8 chunks	+1 line, -66 lines	0 comments	Download
D	tools/dom/src/blink_native_DOMImplementation.dart	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	tools/dom/src/html_native_DOMImplementation.dart	View	1 chunk	+0 lines, -1004 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	19 chunks	+520 lines, -121 lines	0 comments	Download
D	tools/dom/templates/html/dartium/_blink_dartium.darttemplate	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Leaf

6 years, 1 month ago (2014-10-27 23:59:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 41346 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages