Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 680913002: Remove JavaIterator and MapEntry (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -216 lines) Patch
M pkg/analysis_server/lib/src/services/generated/completion.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 6 chunks +11 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 6 chunks +30 lines, -29 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 9 chunks +25 lines, -27 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +0 lines, -59 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 9 chunks +49 lines, -45 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +9 lines, -14 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 3 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-27 14:47:55 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-10-27 15:23:22 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-10-27 15:37:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698