Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 680863002: Remove JavaStringBuilder (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -661 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 7 chunks +29 lines, -33 lines 2 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 40 chunks +238 lines, -254 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 9 chunks +55 lines, -59 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 3 chunks +21 lines, -21 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +0 lines, -30 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 9 chunks +75 lines, -50 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 11 chunks +124 lines, -124 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 1 chunk +2 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/scanner_test.dart View 3 chunks +24 lines, -24 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-26 18:35:14 UTC) #2
scheglov
LGTM https://codereview.chromium.org/680863002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/680863002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode4817 pkg/analyzer/lib/src/generated/ast.dart:4817: buffer.writeCharCode(0x2E); buffer.write('.') here and everywhere else?
6 years, 1 month ago (2014-10-26 19:13:53 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/680863002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/680863002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode4817 pkg/analyzer/lib/src/generated/ast.dart:4817: buffer.writeCharCode(0x2E); > buffer.write('.') here and everywhere else? As long ...
6 years, 1 month ago (2014-10-26 20:16:45 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-10-26 21:49:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698