Issue 21458. Support for 'Add type' Quick Assist in for-each loops.

Issue 21458. Support for 'Add type' Quick Assist in for-each loops.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21458

Committed: https://code.google.com/p/dart/source/detail?r=41403

[Paul Berry, 2014-10-29 20:56:23]

lgtm with test fixed.

https://codereview.chromium.org/680133003/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/correction/assist_test.dart (right):

https://codereview.chromium.org/680133003/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/correction/assist_test.dart:150: int fooBar;
Can we change this to "var fooBar;"?

As written the test is trivially satisfied by the fact that we don't offer the
assist when the type is declared, so it's not testing what you intend.

[scheglov, 2014-10-29 20:59:28]

https://codereview.chromium.org/680133003/diff/1/pkg/analysis_server/test/ser...
File pkg/analysis_server/test/services/correction/assist_test.dart (right):

https://codereview.chromium.org/680133003/diff/1/pkg/analysis_server/test/ser...
pkg/analysis_server/test/services/correction/assist_test.dart:150: int fooBar;
On 2014/10/29 20:56:23, Paul Berry wrote:
> Can we change this to "var fooBar;"?
> 
> As written the test is trivially satisfied by the fact that we don't offer the
> assist when the type is declared, so it's not testing what you intend.

Done.

[scheglov, 2014-10-29 20:59:34]

Committed patchset #1 (id:1) manually as 41403 (presubmit successful).