Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 679923002: Port enums AST changes to Dart. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 4 chunks +19 lines, -1 line 2 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 1 month ago (2014-10-26 17:52:05 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/679923002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/679923002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode15755 pkg/analyzer/lib/src/generated/ast.dart:15755: return identical(this, clause.exceptionParameter) || nit: Personally, I prefer ...
6 years, 1 month ago (2014-10-26 18:36:53 UTC) #2
scheglov
https://codereview.chromium.org/679923002/diff/1/pkg/analyzer/lib/src/generated/ast.dart File pkg/analyzer/lib/src/generated/ast.dart (right): https://codereview.chromium.org/679923002/diff/1/pkg/analyzer/lib/src/generated/ast.dart#newcode15755 pkg/analyzer/lib/src/generated/ast.dart:15755: return identical(this, clause.exceptionParameter) || On 2014/10/26 18:36:53, Brian Wilkerson ...
6 years, 1 month ago (2014-10-26 21:08:08 UTC) #3
scheglov
6 years, 1 month ago (2014-10-26 21:59:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698