Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 679773003: Initialize TokenizerBase int fields for better dart2js codegen. (Closed)

Created:
6 years, 2 months ago by sra1
Modified:
6 years, 2 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Initialize TokenizerBase int fields for better dart2js codegen. This change removes ~15k of needless receiver type checks from csslib due to inferred null values. BUG= R=terry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pkg/csslib/lib/src/tokenizer_base.dart View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
6 years, 2 months ago (2014-10-24 20:43:31 UTC) #2
terry
Wow, LGTM!
6 years, 2 months ago (2014-10-24 21:10:37 UTC) #3
sra1
6 years, 2 months ago (2014-10-24 21:43:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41295 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698