Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 679763002: Add package root support to analysis server. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add package root support to analysis server. Not yet hooked up in Dart editor. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41292

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -59 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +8 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 10 chunks +80 lines, -22 lines 2 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 10 chunks +94 lines, -26 lines 0 comments Download
A pkg/analysis_server/test/integration/analysis/package_root.dart View 1 chunk +67 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-24 16:56:22 UTC) #2
scheglov
lgtm https://codereview.chromium.org/679763002/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/679763002/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode69 pkg/analysis_server/lib/src/context_manager.dart:69: Map<String, String> packageRoots = <String, String>{}; Are we ...
6 years, 2 months ago (2014-10-24 18:45:18 UTC) #3
Paul Berry
https://codereview.chromium.org/679763002/diff/1/pkg/analysis_server/lib/src/context_manager.dart File pkg/analysis_server/lib/src/context_manager.dart (right): https://codereview.chromium.org/679763002/diff/1/pkg/analysis_server/lib/src/context_manager.dart#newcode69 pkg/analysis_server/lib/src/context_manager.dart:69: Map<String, String> packageRoots = <String, String>{}; On 2014/10/24 18:45:18, ...
6 years, 2 months ago (2014-10-24 20:26:50 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-24 20:29:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41292 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698