Issue 679403005: Fix documentation (for issue 19253)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 679403005: Fix documentation (for issue 19253) (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson

Modified:
6 years, 1 month ago

Reviewers:
Paul Berry, scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix documentation (for issue 19253) R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41527

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -64 lines)			Patch
	M	pkg/analyzer/lib/src/generated/element.dart	View		1 chunk	+37 lines, -64 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

These changes look good, however given that issue 19253 was specifically concerned with the method ...

6 years, 1 month ago (2014-11-04 23:55:31 UTC) #3

Brian Wilkerson

Committed patchset #1 (id:1) manually as 41527 (presubmit successful).

6 years, 1 month ago (2014-11-05 17:28:09 UTC) #4

scheglov

6 years, 1 month ago (2014-11-06 16:39:19 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/679403005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/679403005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:2628: * The interface `DartType`
defines the behavior of objects representing the
If it is not [DartType], then it will become out of sync the next time when we
will rename it again.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages