Issue 679153002: Add builder tag for Safari 6.2 slave. Update status files for Safari 6.2.

Issue 679153002: Add builder tag for Safari 6.2 slave. Update status files for Safari 6.2. (Closed)

Created:
6 years, 1 month ago by Bill Hesse

Modified:
6 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add builder tag for Safari 6.2 slave. Update status files for Safari 6.2. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41323

Patch Set 2 : Fix status of string_split test. #

Total comments: 2

Patch Set 3 : Add issue number for html bugs. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -16 lines)			Patch
M	pkg/pkg.status	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1	2 chunks	+3 lines, -7 lines	0 comments	Download
M	tests/html/html.status	View	1 2	3 chunks	+13 lines, -2 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+9 lines, -3 lines	0 comments	Download
M	tools/bots/compiler.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/testing/dart/status_expression.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

lgtm https://codereview.chromium.org/679153002/diff/20001/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/679153002/diff/20001/tests/html/html.status#newcode261 tests/html/html.status:261: element_test/_ElementList: RuntimeError should we have a bug for ...

6 years, 1 month ago (2014-10-27 15:45:45 UTC) #3

Bill Hesse

Committed patchset #3 (id:40001) manually as 41323 (presubmit successful).

6 years, 1 month ago (2014-10-27 16:09:09 UTC) #5

Bill Hesse

6 years, 1 month ago (2014-10-27 16:49:43 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/679153002/diff/20001/tests/html/html.status
File tests/html/html.status (right):

https://codereview.chromium.org/679153002/diff/20001/tests/html/html.status#n...
tests/html/html.status:261: element_test/_ElementList: RuntimeError
On 2014/10/27 15:45:45, ricow1 wrote:
> should we have a bug for these, potentially just a meta bug asking html people
> to triage

Yes.  At first, it looked like nothing else in the file has a bug filed for it,
but now I see that it is mainly "supported" tests that are missing them, so we
may as well file a bug.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages