Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 679113006: Add a debug option to analysis server to specify HTTP port. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add a debug option to analysis server to specify HTTP port. When a port is specified, user may navigate to localhost:$port/status to see the status of analysis. Intended for internal debugging of analysis server only. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41349

Patch Set 1 #

Total comments: 2

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 1 month ago (2014-10-27 23:15:13 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/679113006/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java (right): https://codereview.chromium.org/679113006/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java#newcode116 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java:116: args.add("--debug:" + debugPort); What is the debug port ...
6 years, 1 month ago (2014-10-28 00:10:58 UTC) #3
Paul Berry
https://codereview.chromium.org/679113006/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java File editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java (right): https://codereview.chromium.org/679113006/diff/1/editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java#newcode116 editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/StdioServerSocket.java:116: args.add("--debug:" + debugPort); On 2014/10/28 00:10:58, Brian Wilkerson wrote: ...
6 years, 1 month ago (2014-10-28 00:30:18 UTC) #4
Paul Berry
6 years, 1 month ago (2014-10-28 00:34:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41349 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698