Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 679103003: Support for enums semantic highlighting. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Support for enums semantic highlighting. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41330

Patch Set 1 #

Patch Set 2 : small clean up for tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -6 lines) Patch
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/SemanticHighlightingManager_NEW.java View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 3 chunks +29 lines, -6 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-10-27 17:52:06 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-27 18:20:59 UTC) #2
scheglov
6 years, 1 month ago (2014-10-27 18:39:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41330 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698