Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 678993004: Remove dead code from InvokeDartCode stub. (Closed)

Created:
6 years, 1 month ago by Florian Schneider
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove dead code from InvokeDartCode stub. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41316

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M runtime/vm/stub_code_arm.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 4 chunks +4 lines, -11 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
6 years, 1 month ago (2014-10-27 12:55:27 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/678993004/diff/1/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/678993004/diff/1/runtime/vm/stub_code_arm.cc#newcode875 runtime/vm/stub_code_arm.cc:875: // Load Isolate pointer into CTX. Drop Context. ...
6 years, 1 month ago (2014-10-27 13:16:30 UTC) #3
Florian Schneider
https://codereview.chromium.org/678993004/diff/1/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/678993004/diff/1/runtime/vm/stub_code_arm.cc#newcode875 runtime/vm/stub_code_arm.cc:875: // Load Isolate pointer into CTX. Drop Context. On ...
6 years, 1 month ago (2014-10-27 13:40:52 UTC) #4
Florian Schneider
6 years, 1 month ago (2014-10-27 13:43:24 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r41316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698