Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 677663002: Support constructor invocation in analyzer2dart. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support constructor invocation in analyzer2dart. BUG= R=paulberry@google.com, sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41310

Patch Set 1 #

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -32 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 3 chunks +26 lines, -2 lines 0 comments Download
M pkg/analyzer2dart/lib/src/element_converter.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/lib/src/modely.dart View 3 chunks +64 lines, -15 lines 0 comments Download
M pkg/analyzer2dart/lib/src/tree_shaker.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/analyzer2dart/lib/src/util.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 3 chunks +14 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/mock_libraries.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-10-24 11:19:44 UTC) #2
Paul Berry
lgtm
6 years, 1 month ago (2014-10-24 13:46:01 UTC) #3
sigurdm
lgtm
6 years, 1 month ago (2014-10-27 08:35:32 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-10-27 09:03:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41310 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698