Issue 676743002: IR cleanup: pass deopt id as constructor argument instead of doing deopt_id_ assignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 676743002: IR cleanup: pass deopt id as constructor argument instead of doing deopt_id_ assignment. (Closed)

Created:
6 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
6 years, 2 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

IR cleanup: pass deopt id as constructor argument instead of doing deopt_id_ assignment. This also kills a list of Instruction friends that was growing without bounds. R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41278

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+352 lines, -499 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	4 chunks	+6 lines, -14 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	147 chunks	+281 lines, -428 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	18 chunks	+26 lines, -22 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	6 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View	5 chunks	+8 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	6 chunks	+9 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	5 chunks	+8 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Chromium)

6 years, 2 months ago (2014-10-24 11:27:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41278 (presubmit successful).