Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 676313004: fix bug where dart_support.js could get included above platform.js (Closed)

Created:
6 years, 1 month ago by jakemac
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix bug where dart_support.js could get included above platform.js BUG= http://dartbug.com/21435 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=41331

Patch Set 1 #

Patch Set 2 : style cleanup #

Patch Set 3 : update pubspec/changelog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -10 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 1 3 chunks +20 lines, -6 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/common.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/polymer/test/build/polyfill_injector_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jakemac
6 years, 1 month ago (2014-10-27 17:41:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm
6 years, 1 month ago (2014-10-27 17:59:18 UTC) #3
jakemac
6 years, 1 month ago (2014-10-27 18:48:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698