Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 674223006: Translate Engine utilities tests. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Translate Engine utilities tests. This adds 442 more tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5407 lines, -0 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 3 chunks +28 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +5374 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-10-25 17:44:39 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-25 18:10:44 UTC) #2
scheglov
6 years, 1 month ago (2014-10-25 18:12:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698