Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 673233003: Replace custom EngineTestCase.assertEquals() with 'unorderedEquals'. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace custom EngineTestCase.assertEquals() with 'unorderedEquals'. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -103 lines) Patch
M pkg/analyzer/test/generated/element_test.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +0 lines, -83 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-10-28 16:44:41 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-28 16:59:11 UTC) #2
scheglov
6 years, 1 month ago (2014-10-28 17:00:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41365 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698