Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 673193002: Make stdout/stderr async (Closed)

Created:
6 years, 2 months ago by Søren Gjesse
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Paul Berry
Visibility:
Public.

Description

Make stdout/stderr async This makes stdout.write and stderr.write async. This effectively reverts https://code.google.com/p/dart/source/detail?r=33645 R=iposva@google.com, ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M runtime/bin/stdio_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
I have gotten confirmation from Paul Berry that is solves the deadlock he was experiencing.
6 years, 1 month ago (2014-10-27 15:56:40 UTC) #1
Ivan Posva
LGTM -ip
6 years, 1 month ago (2014-10-27 16:04:04 UTC) #2
Søren Gjesse
6 years, 1 month ago (2014-10-28 08:53:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698