Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672003002: Add package root setting to analysis server API. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Add package root setting to analysis server API. The command does not have any effect yet. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41253

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -76 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/AnalysisServer.java View 1 chunk +9 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 2 chunks +6 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/utilities/RequestUtilities.java View 1 chunk +5 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/MockAnalysisServer.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImplTest.java View 5 chunks +27 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.server_test/src/com/google/dart/server/timing/AnalyzeEngineInServer.java View 2 chunks +3 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/analysis/model/DartProjectManager.java View 1 chunk +2 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/internal/analysis/model/DartProjectManagerTest.java View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analysis_server/doc/api.html View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +12 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 6 chunks +27 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 33 chunks +45 lines, -43 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 1 chunk +15 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +22 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 2 months ago (2014-10-22 20:36:42 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/672003002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/672003002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode410 pkg/analysis_server/tool/spec/spec_input.html:410: then all package: URI's are resolved the normal ...
6 years, 2 months ago (2014-10-22 20:57:08 UTC) #3
Paul Berry
https://codereview.chromium.org/672003002/diff/1/pkg/analysis_server/tool/spec/spec_input.html File pkg/analysis_server/tool/spec/spec_input.html (right): https://codereview.chromium.org/672003002/diff/1/pkg/analysis_server/tool/spec/spec_input.html#newcode410 pkg/analysis_server/tool/spec/spec_input.html:410: then all package: URI's are resolved the normal On ...
6 years, 2 months ago (2014-10-23 00:09:02 UTC) #4
Paul Berry
6 years, 2 months ago (2014-10-23 00:11:50 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698