Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 671023003: More dart:blink entry point tweaks (Closed)

Created:
6 years, 2 months ago by Leaf
Modified:
6 years, 2 months ago
Reviewers:
vsm, terry, sra1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

More dart:html and dart:blink tweaks Methods with no arguments mangled properly (python None and 0 are both false...). Abstract classes generated from pure interfaces have no method bodies. Add missing pure interfaces. Emit dart:blink methods in sorted order. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41288

Patch Set 1 #

Patch Set 2 : Restore interface order #

Patch Set 3 : Pure interface additions #

Patch Set 4 : Restore EventTarget on AbstractWorker #

Patch Set 5 : Static permission getter #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2759 lines, -2156 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 2 3 4 283 chunks +2307 lines, -1686 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 6 chunks +13 lines, -16 lines 2 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 175 chunks +297 lines, -292 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 27 chunks +51 lines, -51 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 11 chunks +20 lines, -20 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 8 chunks +14 lines, -14 lines 0 comments Download
M tools/dom/dom.json View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 2 2 chunks +15 lines, -0 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 2 3 4 9 chunks +31 lines, -69 lines 0 comments Download
D tools/dom/templates/html/impl/impl_AbstractWorker.darttemplate View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Leaf
6 years, 2 months ago (2014-10-22 19:36:53 UTC) #2
Leaf
6 years, 2 months ago (2014-10-22 22:29:00 UTC) #4
vsm
lgtm https://codereview.chromium.org/671023003/diff/80001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/671023003/diff/80001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode130 sdk/lib/html/dart2js/html_dart2js.dart:130: -@Native("AbstractWorker") Did you mean to drop these @Native ...
6 years, 2 months ago (2014-10-23 01:56:26 UTC) #5
sra1
https://codereview.chromium.org/671023003/diff/80001/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://codereview.chromium.org/671023003/diff/80001/sdk/lib/html/dart2js/html_dart2js.dart#oldcode130 sdk/lib/html/dart2js/html_dart2js.dart:130: -@Native("AbstractWorker") On 2014/10/23 01:56:26, vsm wrote: > Did you ...
6 years, 2 months ago (2014-10-23 18:23:20 UTC) #7
Leaf
6 years, 2 months ago (2014-10-24 17:47:21 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 41288 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698