Issue 669733004: Fix http://dartbug.com/21335

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 669733004: Fix http://dartbug.com/21335 (Closed)

Created:
6 years, 2 months ago by Ivan Posva

Modified:
6 years, 2 months ago

Reviewers:
Lasse Reichstein Nielsen, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, regis

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix http://dartbug.com/21335 - Make the VM internal AssertionError, TypeError and CastError implement the public classes instead of patching them. R=asiva@google.com, lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=41231

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	runtime/lib/errors_patch.dart	View		3 chunks	+10 lines, -10 lines	1 comment	Download
	M	runtime/vm/symbols.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/669733004/diff/1/runtime/lib/errors_patch.dart File runtime/lib/errors_patch.dart (right): https://codereview.chromium.org/669733004/diff/1/runtime/lib/errors_patch.dart#newcode18 runtime/lib/errors_patch.dart:18: _AssertionError._create( This constructor doesn't even need to be ...

6 years, 2 months ago (2014-10-21 07:53:43 UTC) #3

Ivan Posva

6 years, 2 months ago (2014-10-21 17:00:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41231 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages