Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 669693002: Support unreachable code in blocks in analyzer2dart. (Closed)

Created:
6 years, 2 months ago by Johnni Winther
Modified:
6 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support unreachable code in blocks in analyzer2dart. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41256

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -10 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_test.dart View 2 chunks +54 lines, -1 line 2 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 2 months ago (2014-10-21 07:22:41 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/669693002/diff/1/pkg/analyzer2dart/test/end2end_test.dart File pkg/analyzer2dart/test/end2end_test.dart (right): https://codereview.chromium.org/669693002/diff/1/pkg/analyzer2dart/test/end2end_test.dart#newcode500 pkg/analyzer2dart/test/end2end_test.dart:500: Maybe it would be beneficial to add a ...
6 years, 2 months ago (2014-10-21 08:22:44 UTC) #3
Johnni Winther
https://codereview.chromium.org/669693002/diff/1/pkg/analyzer2dart/test/end2end_test.dart File pkg/analyzer2dart/test/end2end_test.dart (right): https://codereview.chromium.org/669693002/diff/1/pkg/analyzer2dart/test/end2end_test.dart#newcode500 pkg/analyzer2dart/test/end2end_test.dart:500: On 2014/10/21 08:22:44, sigurdm wrote: > Maybe it would ...
6 years, 2 months ago (2014-10-23 06:55:12 UTC) #4
Johnni Winther
6 years, 2 months ago (2014-10-23 06:58:21 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41256 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698