Add SExpression test and share tests between dart2dart and analyzer2dart.

Add SExpression test and share tests between dart2dart and analyzer2dart.

BUG=
R=paulberry@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41255

[Johnni Winther, 2014-10-22 12:30:21]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[Paul Berry, 2014-10-22 13:03:50]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-10-22 13:03:50]

lgtm

https://codereview.chromium.org/669673006/diff/1/pkg/analyzer2dart/test/test_...
File pkg/analyzer2dart/test/test_helper.dart (right):

https://codereview.chromium.org/669673006/diff/1/pkg/analyzer2dart/test/test_...
pkg/analyzer2dart/test/test_helper.dart:19: class Result {
The name "Result" is confusing because it's not the result of running the test,
it's the specification of what test to run.  Consider renaming the class
"Result" to something else.  ("TestSpec", perhaps?)

https://codereview.chromium.org/669673006/diff/1/pkg/analyzer2dart/test/test_...
pkg/analyzer2dart/test/test_helper.dart:27: typedef CheckResult(Result result);
Similarly, "CheckResult" sounds like a function which takes the output of a test
and verifies that it is correct; it's not clear that it's meant to run the test.
 Consider renaming to something like "RunTest".

[sigurdm, 2014-10-22 13:29:14]

lgtm

[Johnni Winther, 2014-10-23 06:44:02]

https://codereview.chromium.org/669673006/diff/1/pkg/analyzer2dart/test/test_...
File pkg/analyzer2dart/test/test_helper.dart (right):

https://codereview.chromium.org/669673006/diff/1/pkg/analyzer2dart/test/test_...
pkg/analyzer2dart/test/test_helper.dart:19: class Result {
On 2014/10/22 13:03:50, Paul Berry wrote:
> The name "Result" is confusing because it's not the result of running the
test,
> it's the specification of what test to run.  Consider renaming the class
> "Result" to something else.  ("TestSpec", perhaps?)

Done.

https://codereview.chromium.org/669673006/diff/1/pkg/analyzer2dart/test/test_...
pkg/analyzer2dart/test/test_helper.dart:27: typedef CheckResult(Result result);
On 2014/10/22 13:03:50, Paul Berry wrote:
> Similarly, "CheckResult" sounds like a function which takes the output of a
test
> and verifies that it is correct; it's not clear that it's meant to run the
test.
>  Consider renaming to something like "RunTest".

Done.

[Johnni Winther, 2014-10-23 06:45:44]

Committed patchset #2 (id:20001) manually as 41255 (presubmit successful).