Add an integration test to verify that server I/O is asynchronous.

Add an integration test to verify that server I/O is asynchronous.

Currently disabled, since server I/O is currently synchronous.

BUG=dartbug.com/21252
R=danrubel@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41246

[Paul Berry, 2014-10-21 20:15:45]

paulberry@google.com changed reviewers:
+ danrubel@google.com

[danrubel, 2014-10-22 14:56:14]

LGTM

https://codereview.chromium.org/668953002/diff/1/pkg/analysis_server/test/int...
File pkg/analysis_server/test/integration/asynchrony_test.dart (right):

https://codereview.chromium.org/668953002/diff/1/pkg/analysis_server/test/int...
pkg/analysis_server/test/integration/asynchrony_test.dart:50: return
server.flushCommands().then((_) {
Is it possible to add a timeout for the flushCommands so that the test will
continue and fail rather than blocking forever? Does that make sense?

[Paul Berry, 2014-10-22 15:45:02]

On 2014/10/22 14:56:14, danrubel wrote:
> LGTM
> 
>
https://codereview.chromium.org/668953002/diff/1/pkg/analysis_server/test/int...
> File pkg/analysis_server/test/integration/asynchrony_test.dart (right):
> 
>
https://codereview.chromium.org/668953002/diff/1/pkg/analysis_server/test/int...
> pkg/analysis_server/test/integration/asynchrony_test.dart:50: return
> server.flushCommands().then((_) {
> Is it possible to add a timeout for the flushCommands so that the test will
> continue and fail rather than blocking forever? Does that make sense?

It's possible, but I don't think it's worth it.  The test runner infrastructure
(test.py) already implements timeout functionality, so there's no danger of this
causing a buildbot to hang forever.

I'll commit it as is for now; if you feel strongly let me know; I can always do
a follow-up CL.

[Paul Berry, 2014-10-22 15:48:12]

Committed patchset #1 (id:1) manually as 41246 (presubmit successful).

[danrubel, 2014-10-22 15:57:22]

On 2014/10/22 15:45:02, Paul Berry wrote:
> On 2014/10/22 14:56:14, danrubel wrote:
> > LGTM
> > 
> >
>
https://codereview.chromium.org/668953002/diff/1/pkg/analysis_server/test/int...
> > File pkg/analysis_server/test/integration/asynchrony_test.dart (right):
> > 
> >
>
https://codereview.chromium.org/668953002/diff/1/pkg/analysis_server/test/int...
> > pkg/analysis_server/test/integration/asynchrony_test.dart:50: return
> > server.flushCommands().then((_) {
> > Is it possible to add a timeout for the flushCommands so that the test will
> > continue and fail rather than blocking forever? Does that make sense?
> 
> It's possible, but I don't think it's worth it.  The test runner
infrastructure
> (test.py) already implements timeout functionality, so there's no danger of
this
> causing a buildbot to hang forever.
> 
> I'll commit it as is for now; if you feel strongly let me know; I can always
do
> a follow-up CL.

This sounds good to me. No need for any changes.