Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 668743003: Clean up scripts to run Java-based analyzer. (Closed)

Created:
6 years, 2 months ago by Paul Berry
Modified:
6 years, 2 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Clean up scripts to run Java-based analyzer. sdk/bin/dartanalyzer_developer is renamed sdk/bin/dartanalyzer_java (replacing the old sdk/bin/dartanalyzer_java, which was unused), and the test infrastructure is modified to use sdk/bin/dartanalyzer_java to start the Java-based analyzer. This frees up sdk/bin/dartanallyzer_developer to be the --host-checked version of sdk/bin/dartanalyzer (paralleling what we do for /sdk/bin/dart2js_developer). R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -196 lines) Patch
M sdk/bin/dartanalyzer_developer View 1 chunk +2 lines, -64 lines 0 comments Download
M sdk/bin/dartanalyzer_developer.bat View 1 chunk +9 lines, -26 lines 0 comments Download
M sdk/bin/dartanalyzer_java View 3 chunks +27 lines, -49 lines 0 comments Download
M sdk/bin/dartanalyzer_java.bat View 1 chunk +22 lines, -52 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
Note that the diffs on dartanalyzer_java and dartanalyzer_java.bat are misleading. With the exception of a ...
6 years, 2 months ago (2014-10-20 22:03:49 UTC) #2
ricow1
lgtm (and thank you for the very helpful review guidelines)
6 years, 2 months ago (2014-10-21 06:18:32 UTC) #3
Paul Berry
6 years, 2 months ago (2014-10-21 13:02:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698