Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668083002: Better recovery for getters in functions (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Better recovery for getters in functions R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41238

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -13 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/builder/ElementBuilder.java View 1 chunk +1 line, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java View 1 chunk +7 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 3 chunks +17 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 2 months ago (2014-10-21 21:03:04 UTC) #2
scheglov
LGTM https://codereview.chromium.org/668083002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/668083002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode2085 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:2085: } else if (tokenMatchesKeyword(afterReturnType, Keyword.GET)) { Should we ...
6 years, 2 months ago (2014-10-21 21:11:10 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/668083002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java (right): https://codereview.chromium.org/668083002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java#newcode2085 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java:2085: } else if (tokenMatchesKeyword(afterReturnType, Keyword.GET)) { > Should we ...
6 years, 2 months ago (2014-10-21 21:17:09 UTC) #4
Brian Wilkerson
6 years, 2 months ago (2014-10-21 21:17:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41238 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698