Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 666913003: Add timing of serialization (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson
Modified:
6 years, 2 months ago
Reviewers:
scheglov, danrubel
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 3 chunks +10 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/channel.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 2 chunks +10 lines, -2 lines 0 comments Download
A pkg/analyzer/lib/src/util/utilities_timing.dart View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
I'm not sure that this is how we want to gather timing data long term. ...
6 years, 2 months ago (2014-10-23 19:27:59 UTC) #2
scheglov
LGTM
6 years, 2 months ago (2014-10-23 19:31:38 UTC) #3
Brian Wilkerson
6 years, 2 months ago (2014-10-23 19:38:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41270 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698