Support conditional expressions in analyzer2dart.

Support conditional expressions in analyzer2dart.

BUG=
R=sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41188

[Johnni Winther, 2014-10-20 10:16:20]

johnniwinther@google.com changed reviewers:
+ sigurdm@google.com

[sigurdm, 2014-10-20 10:48:32]

lgtm

https://codereview.chromium.org/666863002/diff/40001/pkg/analyzer2dart/lib/sr...
File pkg/analyzer2dart/lib/src/cps_generator.dart (right):

https://codereview.chromium.org/666863002/diff/40001/pkg/analyzer2dart/lib/sr...
pkg/analyzer2dart/lib/src/cps_generator.dart:33: ir.Node visit(AstNode node) =>
node != null ? node.accept(this) : null;
This is not what I expect "visit" to do - it should have another name.
Most times we want to fail immediately if node is null.

https://codereview.chromium.org/666863002/diff/40001/pkg/analyzer2dart/lib/sr...
pkg/analyzer2dart/lib/src/cps_generator.dart:37: build(AstNode node) {
I don't really like the name - the function does not build anything.

[Johnni Winther, 2014-10-20 12:25:13]

https://codereview.chromium.org/666863002/diff/40001/pkg/analyzer2dart/lib/sr...
File pkg/analyzer2dart/lib/src/cps_generator.dart (right):

https://codereview.chromium.org/666863002/diff/40001/pkg/analyzer2dart/lib/sr...
pkg/analyzer2dart/lib/src/cps_generator.dart:33: ir.Node visit(AstNode node) =>
node != null ? node.accept(this) : null;
On 2014/10/20 10:48:32, sigurdm wrote:
> This is not what I expect "visit" to do - it should have another name.
> Most times we want to fail immediately if node is null.

Done.

https://codereview.chromium.org/666863002/diff/40001/pkg/analyzer2dart/lib/sr...
pkg/analyzer2dart/lib/src/cps_generator.dart:37: build(AstNode node) {
On 2014/10/20 10:48:32, sigurdm wrote:
> I don't really like the name - the function does not build anything.

Done.

[Johnni Winther, 2014-10-20 12:27:49]

Committed patchset #4 (id:60001) manually as 41188 (presubmit successful).

[Paul Berry, 2014-10-20 13:43:15]

paulberry@google.com changed reviewers:
+ paulberry@google.com

[Paul Berry, 2014-10-20 13:43:16]

lgtm

https://codereview.chromium.org/666863002/diff/60001/pkg/analyzer2dart/test/e...
File pkg/analyzer2dart/test/end2end_test.dart (right):

https://codereview.chromium.org/666863002/diff/60001/pkg/analyzer2dart/test/e...
pkg/analyzer2dart/test/end2end_test.dart:489: test('If statement', () {
I think you mean 'Conditional expression'