Issue 666543004: Suppress new Request type in dart:html

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 666543004: Suppress new Request type in dart:html (Closed)

Created:
6 years, 2 months ago by vsm

Modified:
6 years, 2 months ago

Reviewers:
terry, blois

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Suppress new Request type in dart:html This is conflicting with the Request type in IDB. Hiding it for now. We may want to expose with a different name or factor out into a service worker library. BUG=http://dartbug.com/21341 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=41208

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -121 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	3 chunks	+61 lines, -61 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	4 chunks	+60 lines, -60 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

vsm

6 years, 2 months ago (2014-10-20 17:57:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41208 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages