Fix version generation for dart2js

Fix version generation for dart2js

Review notes:
This is not at all nice code, and create_snapthot.dart can be rafactored to make this nicer.
This is the least intrusive way I could do this.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30138

[kasperl, 2013-11-10 11:41:18]

LGTM.

https://codereview.chromium.org/66643006/diff/1/utils/compiler/create_snapsho...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/66643006/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:25: import '${dart2js.toFilePath(windows:
false)}' as dart2jsMain;
Is this dead code? You shouldn't remove it now but I'm curious.

https://codereview.chromium.org/66643006/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:54: dart2jsMain.BUILD_ID = "$version";
Less indentation.

[ricow1, 2013-11-10 12:01:59]

https://codereview.chromium.org/66643006/diff/1/utils/compiler/create_snapsho...
File utils/compiler/create_snapshot.dart (right):

https://codereview.chromium.org/66643006/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:25: import '${dart2js.toFilePath(windows:
false)}' as dart2jsMain;
On 2013/11/10 11:41:18, kasperl wrote:
> Is this dead code? You shouldn't remove it now but I'm curious.

Yes this is dead code (and it is probably making dartdoc bloated and slower. You
can actually still do out/ReleaseIA32/dart
out/ReleaseIA32/dart-sdk/bin/snapshot/utils_wrapper.dart.snapshot dart2js
--version and it works, even without this patch

https://codereview.chromium.org/66643006/diff/1/utils/compiler/create_snapsho...
utils/compiler/create_snapshot.dart:54: dart2jsMain.BUILD_ID = "$version";
On 2013/11/10 11:41:18, kasperl wrote:
> Less indentation.

Done.

[ricow1, 2013-11-10 12:02:11]

Committed patchset #2 manually as r30138 (presubmit successful).