Issue 66603002: Improve the HTTP client error when the provided URI is not suitable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 66603002: Improve the HTTP client error when the provided URI is not suitable (Closed)

Created:
7 years, 1 month ago by Søren Gjesse

Modified:
7 years ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Improve the HTTP client error when the provided URI is not suitable This will provide a better error message for e.g. unquoted IPv6 literal addresses (http://::1:8888/) R=whesse@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30151

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comments #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
	M	sdk/lib/io/http_impl.dart	View		1 chunk	+5 lines, -3 lines	0 comments	Download
	M	tests/standalone/io/http_client_exception_test.dart	View	1	1 chunk	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

lgtm https://codereview.chromium.org/66603002/diff/1/tests/standalone/io/http_client_exception_test.dart File tests/standalone/io/http_client_exception_test.dart (right): https://codereview.chromium.org/66603002/diff/1/tests/standalone/io/http_client_exception_test.dart#newcode20 tests/standalone/io/http_client_exception_test.dart:20: () => client.getUrl(Uri.parse('http://::1')), Also add a test for ...

7 years, 1 month ago (2013-11-08 14:54:31 UTC) #2

Søren Gjesse

Committed patchset #2 manually as r30151 (presubmit successful).

7 years, 1 month ago (2013-11-11 11:27:57 UTC) #3

Søren Gjesse

7 years ago (2013-11-28 13:47:19 UTC) #4

Message was sent while issue was closed.

Sending old draft comment.

https://codereview.chromium.org/66603002/diff/1/tests/standalone/io/http_clie...
File tests/standalone/io/http_client_exception_test.dart (right):

https://codereview.chromium.org/66603002/diff/1/tests/standalone/io/http_clie...
tests/standalone/io/http_client_exception_test.dart:20: () =>
client.getUrl(Uri.parse('http://::1')),
On 2013/11/08 14:54:32, Bill Hesse wrote:
> Also add a test for http:///index.html?

Good point. Added http:///, /// and ///index.html as well.

Expand Messages | Collapse Messages