Issue 664743002: Add command-line options for instrumentation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 664743002: Add command-line options for instrumentation (Closed)

Created:
6 years, 2 months ago by Brian Wilkerson

Modified:
6 years, 2 months ago

Reviewers:
Paul Berry, lukechurch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add command-line options for instrumentation R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41171

Patch Set 1 #

Total comments: 1

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -24 lines)			Patch
	M	pkg/analysis_server/lib/driver.dart	View		2 chunks	+29 lines, -24 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

lgtm https://codereview.chromium.org/664743002/diff/1/pkg/analysis_server/lib/driver.dart File pkg/analysis_server/lib/driver.dart (right): https://codereview.chromium.org/664743002/diff/1/pkg/analysis_server/lib/driver.dart#newcode94 pkg/analysis_server/lib/driver.dart:94: // Initialize the instrumentation system with logging. Nit: ...

6 years, 2 months ago (2014-10-17 15:51:43 UTC) #4

Brian Wilkerson

6 years, 2 months ago (2014-10-17 16:47:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41171 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages